Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset quality] Move page to stack management #183406

Open
2 tasks
yngrdyn opened this issue May 14, 2024 · 3 comments
Open
2 tasks

[Dataset quality] Move page to stack management #183406

yngrdyn opened this issue May 14, 2024 · 3 comments
Assignees
@yngrdyn
Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team

Comments

@yngrdyn
Copy link
Contributor

yngrdyn commented May 14, 2024 •
edited

馃摀 Summary

As of now, Dataset quality page is living under logs-explorer application, we want to move the application to Stack management as a new page

Stateful

image

Serverless

image

Additional tasks

鉁旓笍 Acceptance criteria

  • Dataset quality url is now a child of stack management -> Data
  • Logs data quality is shown as a submenu for stateful and a new card is added for it in serverless
  • State is synchronised between URL and page
@botelastic botelastic bot added the needs-team Issues missing a team label label May 14, 2024
@yngrdyn yngrdyn self-assigned this May 14, 2024
@yngrdyn yngrdyn added the Team:obs-ux-logs Observability Logs User Experience Team label May 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 14, 2024
@ruflin
Copy link
Member

ruflin commented May 14, 2024

As part of this, we should also ensure that if no logs dataset exists, we show a proper empty page.

@gbamparop
Copy link
Contributor

As part of this, we should also ensure that if no logs dataset exists, we show a proper empty page.

#183032 is part of the project issue .

@yngrdyn yngrdyn mentioned this issue May 23, 2024
Merged
yngrdyn added a commit that referenced this issue May 29, 2024
@yngrdyn @kibanamachine
[Dataset quality] Move page to stack management > Data (#184122)
d39739e 
Relates to #183406.

## 馃摑  Summary
This PR creates a new plugin `data_quality` in order to register dataset
quality as a Stack management page under data section. For now there is
no reference to this new page in the sideNav in stateful or serverless.

In order to navigate to this new page you can use the url
`/app/management/data/data_quality`

Changes included in this PR:
- New plugin created
- Plugin registered in stack management, data section
- Dataset quality plugin is instantiated and the state is in sync with
URL
- Removed references to dataset quality in Logs explorer

## 馃帴 Demo


https://github.com/elastic/kibana/assets/1313018/501c9c47-4a1b-4f91-9be6-d022a821e88e

## 馃檯馃徏 Missing

- Dataset quality locator
- There are still references to logs explorer (table and flyout) that
will be handled in a follow up PR.

---------

Co-authored-by: kibanamachine <[email protected]>
rshen91 pushed a commit to rshen91/kibana that referenced this issue May 30, 2024
@yngrdyn @kibanamachine @rshen91
[Dataset quality] Move page to stack management > Data (elastic#184122)
e7ca237 
Relates to elastic#183406.

## 馃摑  Summary
This PR creates a new plugin `data_quality` in order to register dataset
quality as a Stack management page under data section. For now there is
no reference to this new page in the sideNav in stateful or serverless.

In order to navigate to this new page you can use the url
`/app/management/data/data_quality`

Changes included in this PR:
- New plugin created
- Plugin registered in stack management, data section
- Dataset quality plugin is instantiated and the state is in sync with
URL
- Removed references to dataset quality in Logs explorer

## 馃帴 Demo


https://github.com/elastic/kibana/assets/1313018/501c9c47-4a1b-4f91-9be6-d022a821e88e

## 馃檯馃徏 Missing

- Dataset quality locator
- There are still references to logs explorer (table and flyout) that
will be handled in a follow up PR.

---------

Co-authored-by: kibanamachine <[email protected]>
@yngrdyn yngrdyn mentioned this issue May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yngrdyn yngrdyn

Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
4 participants
@ruflin @yngrdyn @gbamparop @elasticmachine