Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability AI Assistant] Fix Storybook #183399

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented May 14, 2024

Resolves #183400

Summary

This fixes all broken stories in the Observability AI Assistant storybook.

Screen.Recording.2024-05-14.at.13.54.54.mov

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label May 14, 2024
@CoenWarmer CoenWarmer marked this pull request as ready for review May 14, 2024 12:01
@CoenWarmer CoenWarmer requested a review from a team as a code owner May 14, 2024 12:01
Comment on lines 34 to 44
application: {
navigateToApp: () => {},
},
http: {
basePath: {
prepend: () => '',
},
},
licensing: {
license$: new Subject(),
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the mock contract from core (and other plugins if they have it available)? We can make jest work by adding the following lines to preview.js:

import * as jest from 'jest-mock';

window.jest = jest;

@kibana-ci
Copy link
Collaborator

💔 Build Failed

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Observability AI Assistant] Storybook has broken stories
4 participants