New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiCodeBlock] Support different highlight and annotations colours #7629
Comments
I chatted with @machadoum about this feature and they're moving with a simpler implementation at the moment to get it done by Kibana 8.14. We have more time to work on the details |
@tkajtoch Please let us know if this is still a valid request or if we can close this. |
Let's try to move the conversation to this thread if possible for visibility! |
Hey @r4zr32d3k1l would you mind sharing more details from the design perspective on this feature request? |
We chatted about this last week. One thing that was top of mind for us is figuring out how to maintain color contrast -- prism supports a wide variety of languages with variations in syntax highlighting, so we'd need to make sure we're using colors that work well across the board. Other aspects of this seem simpler -- like adding the ability to configure which icons are shown for annotations, which seems like it might improve the user experience for you. I wonder if that alone would be enough to accommodate your use case. The other thing we weigh here is how generally useful a feature. Do you think there are use cases for this outside of this one particular use case? |
@r4zr32d3k1l @machadoum Any other thoughts on this? If you have some concrete ideas to make this more tangible we would happy to pursue this further, but as it is now we'll need some help making this a more concrete feature request. |
@JasonStoltz Regarding usability, having the ability to display code is beneficial, and it’s always good to have the capability to show errors if we can detect them. So yes, I'm hopeful that we can identify other use cases where this feature could be applied. |
Is your feature request related to a problem? Please describe.
We want to highlight lines with warnings and errors on a CSV file uploader.
Describe the solution you'd like
Allow
EuiCodeBlock
componentlineNumbers.highlight
andlineNumbers.annotations
colour customization.Describe alternatives you've considered
We don't need advanced colour customization for our use case, so it would be fine if
EuiCodeBlock
only allows us to set the colour from a small subset, such as'info' | 'warning' | 'error'
.Desired timeline
Our goal is to deliver the feature on April 16, 2024. Given the short notice, we may need to simplify the design.
The text was updated successfully, but these errors were encountered: