Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Loki to test open PRs in CI #7617

Open
tkajtoch opened this issue Mar 25, 2024 · 2 comments · May be fixed by #7747
Open

Configure Loki to test open PRs in CI #7617

tkajtoch opened this issue Mar 25, 2024 · 2 comments · May be fixed by #7747
Assignees
@tkajtoch
Labels
task A task associated with a larger Meta issue

Comments

@tkajtoch
Copy link
Member

tkajtoch commented Mar 25, 2024 •
edited

Summary

Loki is a Visual Regression Testing software that integrates with Storybook. We need to run it in CI for every open PR to ensure no unwanted UI changes get merged to main.

Please follow the guide on Loki's website: https://loki.js.org/continuous-integration.html.

Due to the architecture of our current CI pipeline, Loki CI step should depend on the eui-pull-request-deploy-docs step since it depends on Storybook being deployed.

Acceptance Criteria

  • Loki should run as a separate CI step after Storybook is built and deployed
  • loki command should be executed with the --requireReference flag and CI=true environment variable set
  • failed tests should result in a failed step status and blocked PR merge
@tkajtoch tkajtoch added the task A task associated with a larger Meta issue label Mar 28, 2024
@tkajtoch
Copy link
Member Author

The blocking issue has just been merged

@tkajtoch tkajtoch linked a pull request May 13, 2024 that will close this issue
Draft
@tkajtoch
Copy link
Member Author

Will be unblocked and ready for review when https://github.com/elastic/ci-agent-images/pull/691 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkajtoch tkajtoch

Labels
task A task associated with a larger Meta issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: Add loki step to CI tkajtoch/eui
1 participant
@tkajtoch