Skip to content

Commit 7e0ac58

Browse files
authored
Fix: Add NamedWriteable for RuleQueryRankDoc (#128153) (#128268)
* Add NamedWriteable for QueryRule rank doc * Update test * Update docs/changelog/128153.yaml * Add multi cluster test for query rules * Commenting out code - explicitly trying to spur a test failure * [CI] Auto commit changes from spotless * Streamline test for multi cluster * Revert changes to try to break test * Fix compile error --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit b335c1a) # Conflicts: # x-pack/plugin/ent-search/qa/rest/src/yamlRestTest/resources/rest-api-spec/test/entsearch/rules/40_rule_query_search.yml
1 parent 940b441 commit 7e0ac58

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

docs/changelog/128153.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
pr: 128153
2+
summary: "Fix: Add `NamedWriteable` for `RuleQueryRankDoc`"
3+
area: Relevance
4+
type: bug
5+
issues:
6+
- 126071

x-pack/plugin/ent-search/src/main/java/org/elasticsearch/xpack/application/EnterpriseSearch.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import org.elasticsearch.plugins.SystemIndexPlugin;
3131
import org.elasticsearch.rest.RestController;
3232
import org.elasticsearch.rest.RestHandler;
33+
import org.elasticsearch.search.rank.RankDoc;
3334
import org.elasticsearch.xcontent.ParseField;
3435
import org.elasticsearch.xpack.application.analytics.AnalyticsTemplateRegistry;
3536
import org.elasticsearch.xpack.application.analytics.action.DeleteAnalyticsCollectionAction;
@@ -179,6 +180,7 @@
179180
import org.elasticsearch.xpack.application.rules.action.TransportPutQueryRulesetAction;
180181
import org.elasticsearch.xpack.application.rules.action.TransportTestQueryRulesetAction;
181182
import org.elasticsearch.xpack.application.rules.retriever.QueryRuleRetrieverBuilder;
183+
import org.elasticsearch.xpack.application.rules.retriever.RuleQueryRankDoc;
182184
import org.elasticsearch.xpack.application.search.SearchApplicationIndexService;
183185
import org.elasticsearch.xpack.application.search.action.DeleteSearchApplicationAction;
184186
import org.elasticsearch.xpack.application.search.action.GetSearchApplicationAction;
@@ -347,6 +349,11 @@ protected XPackLicenseState getLicenseState() {
347349
return Collections.unmodifiableList(actionHandlers);
348350
}
349351

352+
@Override
353+
public List<NamedWriteableRegistry.Entry> getNamedWriteables() {
354+
return List.of(new NamedWriteableRegistry.Entry(RankDoc.class, RuleQueryRankDoc.NAME, RuleQueryRankDoc::new));
355+
}
356+
350357
@Override
351358
public List<RestHandler> getRestHandlers(
352359
Settings settings,

0 commit comments

Comments
 (0)