Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use self.client instead of client #1032

Closed
wants to merge 1 commit into from
Closed

Use self.client instead of client #1032

wants to merge 1 commit into from

Conversation

adibsaad
Copy link

@adibsaad adibsaad commented Jun 9, 2022

Should fix #1004 (also mentioned here elastic/elasticsearch-ruby#1344 (comment))

When deleting an index that doesn't exist, the exception handler references client but I think it should be referencing self.client

@cla-checker-service
Copy link

cla-checker-service bot commented Jun 9, 2022 •
edited

💚 CLA has been signed

@Lolote13
Copy link

Lolote13 commented Jul 3, 2022 •
edited

Hello, can someone review this ? I have the same issue

vbrazo
vbrazo approved these changes Jul 21, 2022
View reviewed changes
Copy link

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review this PR as it is blocking me

@sebfie
Copy link

sebfie commented Sep 16, 2022

up ?

@kalashnikovisme
Copy link

kalashnikovisme commented Oct 3, 2022 •
edited

I've catch error #1004

Added gem 'elasticsearch-rails', github: 'adibsaad/elasticsearch-rails', branch: 'patch-1' instead of main version.

Unfortunately, the error is still the same.

NoMethodError: undefined method `transport' for #<Elasticsearch::Transport::Transport::HTTP::Faraday:0x0000564e78127498>
/bundle/ruby/2.7.0/bundler/gems/elasticsearch-rails-a0b81a691fd3/elasticsearch-model/lib/elasticsearch/model/indexing.rb:293:in `rescue in delete_index!'
/bundle/ruby/2.7.0/bundler/gems/elasticsearch-rails-a0b81a691fd3/elasticsearch-model/lib/elasticsearch/model/indexing.rb:289:in `delete_index!'
/bundle/ruby/2.7.0/bundler/gems/elasticsearch-rails-a0b81a691fd3/elasticsearch-model/lib/elasticsearch/model/indexing.rb:248:in `create_index!'

@adibsaad adibsaad closed this by deleting the head repository Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create_index! raises undefined method transport @ 7.2.0
5 participants
@adibsaad @Lolote13 @sebfie @kalashnikovisme @vbrazo