Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTI checks while OC-Server is not responding #941

Open
ssrahn opened this issue Feb 26, 2024 · 0 comments
Open

LTI checks while OC-Server is not responding #941

ssrahn opened this issue Feb 26, 2024 · 0 comments
Labels
type:bug v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x

Comments

@ssrahn
Copy link
Collaborator

ssrahn commented Feb 26, 2024

  • AXIOS has no timeout by default
  • Plugin continuously sends new lti requests - page loads continuously
    • It seems there is only a max. number of failed requests - without timeout they wont fail
  • No indication on the front-end, it looks like there is a valid connection
  • At some point a "CORS Failed" comes through with error code "ERR_NETWORK"
    • But takes a long time
    • Timeout error code would be ECONNABORTED
  • Uploading and editing videos is allowed during this time
    • The upload appears as if it hangs on confirmation (Because it also uses a AXIOS request)
    • Editing throws an error immediately

My suggestion:

  • Set max value for simultaneous lti check requests
    • It probably only should do one request at a time
  • Show Message like "Verbindung zum OpenCast Server wird aufgebaut..." while LTI checks are running
  • Disallow Video upload and editing while LTI checks are running (hide or grey out)
    • Or show message in dialog when clicking on upload/edit, explaining that it doesn't work right now
  • (Set timeout for AXIOS calls)
    • No timeout wont be a problem if handled correctly. Do we want a timeout?

Could have something to do with #551

@ssrahn ssrahn added type:bug v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x labels Feb 26, 2024
@ssrahn ssrahn self-assigned this Feb 26, 2024
@ssrahn ssrahn removed their assignment Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x
Projects
None yet
Development

No branches or pull requests

1 participant