Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume control elements for video preview #941

Open
cgruber-uos opened this issue Jun 3, 2022 · 2 comments
Open

Add volume control elements for video preview #941

cgruber-uos opened this issue Jun 3, 2022 · 2 comments

Comments

@cgruber-uos
Copy link

Today @naweidner and I did a walk through OC Studio about A11y support via shortkeys. On the video player for preview before download / publication we noticed common interaction elements like play / pause / seeking but no volume controle. Of cause you can use the system volume control, but for A11y reasons I would expect some basic controlls like

  • volume up / down and
  • mute

nearby the video. Is there any reason - beside simplicity - to abstain from this? As I have seen video is included via <video> and volume control elements should be technically possible.

2022-06-03 23_20_39-Greenshot

@lkiesow
Copy link
Contributor

lkiesow commented Dec 23, 2022

There should be no technical problem in adding something like that. The FontAwesome icon set we use should also have icons for that. We should keep it simple though. Maybe something like this:

171957569-257cb5f5-8325-4a73-9c67-68120c72b0d7

@Dhananjay-12
Copy link

Hi @lkiesow , I want to try this but need some time to get understanding of react.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants