-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seeing info level logs with minimum-level
set to Warn
#814
Comments
I may be totally off base about the default config thing. I was going to fix it but I don't actually see a default config file in this repo that looks like the one on the website. In that case I'm not sure what's happening but I was definitely seeing info level logs before adding those overrides and not afterwards. |
I fixed it locally by adding this:
This makes the minimum level universal as I was expecting. If there is a default config file somewhere shared between runtime and the website perhaps that could be an option. Let's you document that option with a functional example that doesn't change runtime behavior for those loggers. |
Hi @mdegat01 - I think you are completely right here. The default config is here: https://github.com/eikek/sharry/blob/master/modules/restserver/src/main/resources/reference.conf - This is exactly the same file you see on the website. You are also right about the initial line - then the config has not been applied as it is just reading the file. It's ok to me to remove the default overrides - they are there to have the same logging as before the change with overriding loggers (it was always conigured like this). And it's a mix of loggers that can be useful in case of error. But I can understand the confusion. I can comment it out and then all who want to have this must change their config. So there may be disagreement on the other side 😄 |
In my sharry config
logging
is set up like this:As you can see, I have set it to
Warn
level and there are no overrides for specific loggers. However I still see info level logs on startup:I wondered if perhaps this was because the default config listed overrides for these particular loggers. So as a test I tried adding this to my config and restarting:
That fixed the issue. After that I saw exactly one info level log, this one:
I assume that's because it has not processed the config yet and determined the minimum level.
I can adjust my config to account for this. But I think the default config should not include overrides for particular loggers. I get why it shows that on the website as an example but I think those should be commented out in the actual config.
The text was updated successfully, but these errors were encountered: