Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert any popup into a normal window (tab) #3

Open
eight04 opened this issue Oct 1, 2017 · 1 comment
Open

Convert any popup into a normal window (tab) #3

eight04 opened this issue Oct 1, 2017 · 1 comment

Comments

@eight04
Copy link
Owner

eight04 commented Oct 1, 2017

https://addons.mozilla.org/zh-tw/firefox/addon/popup-tab/reviews/926206/
@eight04
Copy link
Owner Author

eight04 commented Oct 24, 2017

A "popup" created by page script (window.open()) is actually a normal window (WindowType === "normal"), so it is impossible to determine whether the window is a popup (without the tab bar) and update the contextmenu.

I guess it would be better to use an addon like https://addons.mozilla.org/en-US/firefox/addon/otherwindow/?src=search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eight04