Skip to content

Commit 453b5fd

Browse files
committed
fix(ci): Move differential shellcheck to its own workflow
It is not supported in scheduled runs, and fails. Signed-off-by: Edwin Török <[email protected]>
1 parent b27ecda commit 453b5fd

File tree

2 files changed

+32
-22
lines changed

2 files changed

+32
-22
lines changed

.github/workflows/main.yml

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -12,28 +12,6 @@ concurrency: # On new push, cancel old workflows from the same PR, branch or ta
1212
cancel-in-progress: true
1313

1414
jobs:
15-
# https://www.shellcheck.net/wiki/GitHub-Actions
16-
# https://github.com/redhat-plumbers-in-action/differential-shellcheck?tab=readme-ov-file#usage
17-
shell-test:
18-
name: Differential ShellCheck
19-
runs-on: ubuntu-latest
20-
21-
permissions:
22-
security-events: write
23-
24-
steps:
25-
- name: Checkout code
26-
uses: actions/checkout@v4
27-
with:
28-
fetch-depth: 0
29-
30-
# If needed severity levels can be controlled here
31-
# severity: warning
32-
- name: Differential ShellCheck
33-
uses: redhat-plumbers-in-action/differential-shellcheck@v5
34-
with:
35-
token: ${{ secrets.GITHUB_TOKEN }}
36-
3715
python-test:
3816
name: Python tests
3917
runs-on: ubuntu-22.04

.github/workflows/shellcheck.yaml

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
name: ShellCheck
2+
3+
on:
4+
push:
5+
pull_request:
6+
7+
concurrency: # On new push, cancel old workflows from the same PR, branch or tag:
8+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
9+
cancel-in-progress: true
10+
11+
jobs:
12+
# https://www.shellcheck.net/wiki/GitHub-Actions
13+
# https://github.com/redhat-plumbers-in-action/differential-shellcheck?tab=readme-ov-file#usage
14+
shell-test:
15+
name: Differential ShellCheck
16+
runs-on: ubuntu-latest
17+
18+
permissions:
19+
security-events: write
20+
21+
steps:
22+
- name: Checkout code
23+
uses: actions/checkout@v4
24+
with:
25+
fetch-depth: 0
26+
27+
# If needed severity levels can be controlled here
28+
# severity: warning
29+
- name: Differential ShellCheck
30+
uses: redhat-plumbers-in-action/differential-shellcheck@v5
31+
with:
32+
token: ${{ secrets.GITHUB_TOKEN }}

0 commit comments

Comments
 (0)