Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List restaurants, meals, and hours from cli #7

Open
ipwnponies opened this issue Mar 20, 2019 · 4 comments
Open

List restaurants, meals, and hours from cli #7

ipwnponies opened this issue Mar 20, 2019 · 4 comments
Assignees

Comments

@ipwnponies
Copy link
Collaborator

We can cache the response of the restaurant/meal/hours queries. This will provide users ability to lookup possible inputs to provide as arguments.

Meals might be trickier, since they can change day-to-day. That can be a follow-up to this ticket, the benefit of getting reasonable inputs to provide to CLI arguments is great enough on its own.

@edmundmok
Copy link
Owner

To add on to the caching of meals, here are some relevant thoughts:

  • From my experience, most restaurants have a fixed rotation of menus per week, so it might make sense to simply cache each restaurant’s item for a particular day, and possibly invalidate an outdated menu item if detected to be “incorrect”.
  • Having a “preference” ranking instead of a single menu item, which can help with the possibility that a certain menu item that was chosen is unavailable for some reason, and allows the script to fallback to another option.

@edmundmok
Copy link
Owner

By the way, it seems like I can still access the API with an account that is no longer subscribed (though I probably can't order anything), so I can try to help out with some of these issues.

@ipwnponies
Copy link
Collaborator Author

For v1, we can simply be naive and cache the last meal.
For v2, we can cache meals per day of week.

Preference ranking with fallback behaviour is a great feature and enough work to warrant its own ticket (#9)

@ipwnponies
Copy link
Collaborator Author

By the way, it seems like I can still access the API with an account that is no longer subscribed (though I probably can't order anything), so I can try to help out with some of these issues.

lol today was actually my last meal on the plan (putting it on hold for the next several weeks). So I was frantically dumping all the response for analyzing later. It's good to know that I can still use the api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants