-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding ability to define amount of tints/shades generated #32
Comments
Thanks @mevsme, I like this idea and it’s pretty common in other color picker apps. This would add a significant amount of complexity to the code and interface so anyone considering a contribution for this should kick off a discussion here first. |
@edelstone In terms of UI complexity, I think it would remain simple because we currently scroll any horizontal overflows, right? So it's probably a matter of just adding an input somewhere, listening to it, and setting a variable in the script to dictate the number of shades to generate instead of using the hardcoded Thoughts? |
Yeah I tolerated the horizontal scrolling as a solution for smaller devices; not sure I’d love that for desktop browsers, although we could also widen the constraints generally (which are fairly narrow now). We did just add the switch for hashtag copying and I’m thinking about having a dark mode switch somewhere in the interface so I want to be careful about all the inputs. You want to contribute something on this @AleksandrHovhannisyan ? |
Yeah, I agree; it may end up looking cluttered. Maybe some kind of settings menu?
Maybe! Just throwing some ideas out there. Anyone else who wants to bite is more than welcome to do so. |
That's an option or I think these switches would logically fall in three different places in the interface:
If we can truly persist all the options across a user's sessions, then a settings panel may work better. If we don't do that I'm not so sure it would be. As far as placement goes, perhaps a settings gear icon or text button would be at the top of the interface and open either in a dialog or its own page entirely.
The correct percentages in the color calculations would also need to be calculated. Right now we multiple by
Many thanks for the ideas and conversation! |
Yep, that's fine! You could calculate |
Oh btw, one way to do this:
We could use Since the UI is bound to get more busy, maybe we should mock something up and see what we like. |
I can do that. I’m thinking this local storage should perhaps just be its own issue. It seems like it can be easily decoupled from the other settings issues. |
Here’s option one (option two in next comment) where all the settings are present on the page. It includes the dark mode switch from #31 which I'll probably do in my free time (since it's within my abilities). As we've been discussing, it would probably be good to do #33 (persist settings) before or in parallel with this, especially if we go with a settings menu dialog. I should have more designs up shortly, but feel free to comment. Notes:
Figma files hereStatic pageSelect menu selected |
OK option number two here. Some notes:
Figma files hereCog/gear icon SVGStatic pageHover effectModal activatedSelect menu selected |
Feel free to comment or post alternate designs of any fidelity. I can go another round on this. |
@mevsme FYI, I found this other tool that has an identical color calculation method to the Tint and Shade Generator but also permits more/less than 10 shades and tints. Very flexible and well-implemented tool. https://noeldelgado.github.io/shadowlord CC: @mustafa-online and @avks |
for example I would like to have 20 shades instead of 11
The text was updated successfully, but these errors were encountered: