Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for KubeSchedulerConfiguration #874

Open
ddelange opened this issue Jan 4, 2023 · 16 comments · May be fixed by #893
Open

Support for KubeSchedulerConfiguration #874

ddelange opened this issue Jan 4, 2023 · 16 comments · May be fixed by #893

Comments

@ddelange
Copy link

ddelange commented Jan 4, 2023

Hi 👋

I want to run kube-scheduler with the MostAllocated scoring strategy for compatibility with descheduler HighNodeUtilization strategy: https://github.com/kubernetes-sigs/descheduler/tree/v0.23.1#highnodeutilization

As of 1.25.0 (kubernetes/kops@9bb1d3e) kops has support for KubeSchedulerConfiguration (since --policy-configmap has been deprecated) ref kubernetes/kops#13352

It's behind a feature-gate ref https://kops.sigs.k8s.io/addon_objects/#kubeschedulerconfiguration-group-kubeschedulerconfigk8sio

I think it's not yet implemented on the terraform provider: https://registry.terraform.io/providers/eddycharly/kops/latest/docs/resources/cluster#kube_scheduler_config

Or did I miss something?

@eddycharly
Copy link
Owner

Hi, thanks for reporting.
Chances are that it’s not supported, I will look at it asap.

@eddycharly
Copy link
Owner

Feature flags are supported at the provider config level though.
Not sure how the file itself should be passed.

@ddelange
Copy link
Author

ddelange commented Jan 5, 2023

I haven't looked at the file mechanic in detail, but in kubernetes/kops@9bb1d3e, judging from the multi-resource yaml pkg/model/components/kubescheduler/tests/kubeschedulerconfig/cluster.yaml, it would look to me like a user-specified yaml can be applied after (?) the cluster creation 🤔

@eddycharly
Copy link
Owner

eddycharly commented Jan 16, 2023

@ddelange did you try to enable the feature flag in the provider config ?

provider "kops" {
  feature_flags = [ "ClusterAddons" ]
}

It won't be enough though, I need to add addons support.

@ddelange
Copy link
Author

oh nice, no haven't had the time yet!

@eddycharly eddycharly linked a pull request Jan 23, 2023 that will close this issue
@eddycharly
Copy link
Owner

@ddelange do you think you could give a try to #893 ?

@ddelange
Copy link
Author

that looks great! :) I don't know when I can make time to run a real world test, but I will try to get around to it! Feel free to merge without my confirmation though ;)

@eddycharly
Copy link
Owner

eddycharly commented Jan 23, 2023

I will merge once you can confirm it works ;)
I actually don't have access to an aws account to give it a try myself.

@ddelange
Copy link
Author

ok, I'll get back to you!

@BartoszZawadzki
Copy link

Hi guys,

what's the status of this issue?

@eddycharly
Copy link
Owner

@BartoszZawadzki
Copy link

@eddycharly So basically I have to use kops terraform provider in order to be able to use KubeSchedulerConfiguration ? There's no way to use it with our current kops yaml manifest?

@eddycharly
Copy link
Owner

@BartoszZawadzki TBH i'm not sure, i didn't work on it for some time. The project moved to https://github.com/terraform-kops/terraform-provider-kops. This repo is no longer active.

@ddelange
Copy link
Author

does it make sense to add a forwarding banner on top of README and archive the repo?

@eddycharly
Copy link
Owner

@ddelange yes, i will probably do that

@BartoszZawadzki
Copy link

@eddycharly Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants