Merge pull request #9 from edanalytics/bugfix/student_keys

fix student key issues

Author: ejoranlienea

models/oneroster_1_1/or1_1__int_users_student.sql

@@ -13,7 +13,7 @@ student_school as (
     where school_year = {{ var('oneroster:active_school_year')}}
 ),
 dim_school as (
-    select * from {{ ref('dim_school') }}
+    select * exclude tenant_code from {{ ref('dim_school') }}
 ),
 grade_level_xwalk as (
     select * from {{ ref('xwalk_oneroster_grade_levels') }}
@@ -44,6 +44,8 @@ student_orgs as (
         dim_school.k_school,
         dim_school.school_id,
         {{ gen_sourced_id('school') }} as sourced_id,
+        student_school.is_primary_school,
+        student_school.entry_date,
         student_school.tenant_code
     from student_school
     join dim_school 
@@ -54,8 +56,8 @@ student_orgs_agg as (
         k_student,
         listagg(distinct sourced_id, ',') as orgs,
         -- create columns for primary school extension
-        max_by(sourced_id, is_primary_school, 1)[0] as primary_school_sourced_id,
-        max_by(sourced_id, entry_date, 1)[0] as latest_school_sourced_id
+        max_by(sourced_id, is_primary_school, 1)[0]::string as primary_school_sourced_id,
+        max_by(sourced_id, entry_date, 1)[0]::string as latest_school_sourced_id
     from student_orgs
     group by all
 ),
@@ -97,10 +99,8 @@ formatted as (
         on dim_student.k_student = student_orgs_agg.k_student
     left join user_ids
         on dim_student.k_student = user_ids.k_student
-        and student_orgs_agg.k_lea = user_ids.k_lea
-    left join student_email 
-        on dim_student.k_student = student_email.k_student 
-        and student_orgs_agg.k_lea = student_email.k_lea
+    left join student_email
+        on dim_student.k_student = student_email.k_student
     left join grade_level_xwalk 
         on dim_student.grade_level = grade_level_xwalk.edfi_grade_level
 )