Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the user maintain a list of trusted hosts or resources. #1571

Open
jukzi opened this issue Aug 4, 2023 · 1 comment
Open

Let the user maintain a list of trusted hosts or resources. #1571

jukzi opened this issue Aug 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jukzi
Copy link

jukzi commented Aug 4, 2023

Instead of only globally enable/disable download of external resources it would be more secure to allow only some resources to be automatically downloaded.
i.e. provide multiple quickfixes like
a) "Download all resources from http://springframework.com/**"
b) "Download resource from http://springframework.com/dtd/spring-beans-1.0.dtd"
c) "Enable download resources from all hosts (NOT RECOMMENDED)"

forked from:
eclipse-wildwebdeveloper/wildwebdeveloper#1289 (comment)

Also it may be a good idea to - by default - use https instead of http when possible even if the link specifies "http".

@angelozerr
Copy link
Contributor

angelozerr commented Aug 4, 2023

Instead of only globally enable/disable download of external resources

I think we should keep it.

To manage allowed url, I think we should have:

  • a new settings where you can declare a list of allowed url
  • those allowed url could use pattern (ex : http://**/foo)

So those settings could be updated at hand by the user.

For quickfix,

  • the a) is a very good idea and should update the new settings
  • the b) already exists but it should update this new settings to allow the download when lemminx cache is evicted
  • the c) as you said it is not recommended

@angelozerr angelozerr added the enhancement New feature or request label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants