-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record rules during profiling of ETL scripts (fixes #51) #52
base: main
Are you sure you want to change the base?
Conversation
d2567c5
to
b6a03ec
Compare
All tests are passing locally. Waiting for Jenkins results. |
Tests are green on Jenkins as well. |
Dimitris, what are your thoughts on this PR? |
I think this PR is ready @kolovos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch for ETL looks good to me, although ideally we’d also want to include guard execution time (and possibly super-rule execution time). On a more general note, the Rules tab doesn’t seem to be working with other languages of Epsilon either (I’ve tried EVL and ECL/EML but nothing shows up). It may be the case that instead of patching ETL we’re better off temporarily removing the Rules tab until we have a consistent solution for all Epsilon languages.
This PR is to fix issue #51. The problem was that the RuleProfiler never gets to screen a
TransformationRule
, because itsexecuteSuperRulesAndBody
method directly executes the bodyStatementBlock
so theTransformationRule
never goes through the preExecute and postExecute methods of the execution controller.I have moved the place from which the body is run:
TransformationRule
now implementsIExecutableModuleElementParameter
, and theexecuteSuperRulesAndBody
method sets everything up and then puts theTransformationRule
through the execution controller as usual.I also had to modify the
ExecutionProfiler
, as it assumed that you would never nest rule executions. Turns out this is wrong: an ETL rule can trigger a lazy ETL rule, for instance (or you could use thesatisfies(...)
operation in EVL).This pull request is only a draft for now, since I'd like for someone else to look at this and tell me if the approach is correct before I start adding automated tests for it. @kolovos, could you give it a look?