Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom Compression/Decompressino #67

Open
MRuecker opened this issue Jun 19, 2023 · 6 comments
Open

Support custom Compression/Decompressino #67

MRuecker opened this issue Jun 19, 2023 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@MRuecker
Copy link

Describe the feature

We are using the older (Netty) version of the gRPC Server and implemented custom Snappy compression/decompression. We extended the (De)Compressor registry and registered it in the GrpcServer builder via

  • compressorRegistry
  • decompressorRegistry

I couldn't find any option to register custom (de)compressors in grpc-netty

Use cases

This feature is usefull when you need to compress the payload and don't want to use gzip because it's very heavy on CPU. I our case we decided to use Snappy because is comes with a nice balance between CPU usage and compression ratio

Contribution

I'm happy to implement this feature and it might be enough to just allow a custom Compressor/Decompressor Registry to be added to the GrpcServiceBridge and use them instead of the default registries to find the compressor needed.
But I'm not sure

Thanks you
Markus

@MRuecker MRuecker added the enhancement New feature or request label Jun 19, 2023
@liangyuanpeng
Copy link

I think it's useful, cc @vietj

@vietj
Copy link
Member

vietj commented Oct 13, 2023

@MRuecker currently compression is hardcoded in GrpcClientRequest and GrpcServerResponse and only works with GZIP, so you would like to register other compression algorithms ?

@vietj vietj added this to the 5.0.0 milestone Oct 13, 2023
@MRuecker
Copy link
Author

Yes we are currently using snappy because GZIP is too heavy on CPU

@franz1981
Copy link
Contributor

what's the status of this @vietj @MRuecker ?

@vietj
Copy link
Member

vietj commented Feb 12, 2024

I think we should have support for any compression actually

@franz1981
Copy link
Contributor

franz1981 commented Feb 12, 2024

yeah, at least snappy is very used (and I'm recently working with @lucamolteni to get it decent for us as well) and PRs are welcome as you might know ihih, so , join the party!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants