-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom Compression/Decompressino #67
Comments
I think it's useful, cc @vietj |
@MRuecker currently compression is hardcoded in |
Yes we are currently using snappy because GZIP is too heavy on CPU |
I think we should have support for any compression actually |
yeah, at least |
Describe the feature
We are using the older (Netty) version of the gRPC Server and implemented custom Snappy compression/decompression. We extended the (De)Compressor registry and registered it in the GrpcServer builder via
I couldn't find any option to register custom (de)compressors in grpc-netty
Use cases
This feature is usefull when you need to compress the payload and don't want to use gzip because it's very heavy on CPU. I our case we decided to use Snappy because is comes with a nice balance between CPU usage and compression ratio
Contribution
I'm happy to implement this feature and it might be enough to just allow a custom Compressor/Decompressor Registry to be added to the GrpcServiceBridge and use them instead of the default registries to find the compressor needed.
But I'm not sure
Thanks you
Markus
The text was updated successfully, but these errors were encountered: