Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theia AI] Diff editor line wrapping #15105

Open
Tracked by #15068
JonasHelming opened this issue Mar 4, 2025 · 2 comments · May be fixed by #15161
Open
Tracked by #15068

[Theia AI] Diff editor line wrapping #15105

JonasHelming opened this issue Mar 4, 2025 · 2 comments · May be fixed by #15161
Assignees

Comments

@JonasHelming
Copy link
Contributor

JonasHelming commented Mar 4, 2025

The diff editor does not use line wrapping on the left side, but uses line wrapping on the right hand side. This makes the diff editor hard to use for text documents. I did not see a setting to switch line wrapping for the diff editor. This applies for the change set diff editor, but also the regular triggered from the git view.

@JonasHelming JonasHelming changed the title [Theia AI] Diff editor line wrapping | The diff editor does not use line wrapping on the left side, but uses line wrapping on the right hand side. This makes the diff editor hard to use for text documents. I did not see a setting to switch line wrapping for the diff editor. [Theia AI] Diff editor line wrapping Mar 4, 2025
@colin-grant-work
Copy link
Contributor

First observation: It looks like no matter what the values of the underlying preferences, the values read at this point in the Monaco editor are all off:

https://github.com/microsoft/vscode/blob/a82cb134776649a3678f4fc21be007653c1f964a/src/vs/editor/common/config/editorOptions.ts#L2697-L2702

@colin-grant-work
Copy link
Contributor

I believe our problem has to do with what's described here, since at the time that the code to create the widget runs, the div that will house it isn't attached, so we always run into the logic that sets wordWrapOverride2 to 'off'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants