-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the hashtable related code by checking the node count #211
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The issue was detected when adjusting the thunk heap related code via eclipse-openj9/openj9#19852, in which we found that the code in
hashTableForEachDo()
still relies on the node count to determine whether to move forward to check the hashtable but there are still a bunch of code/assignments before returning null for a empty hashtable. Instead, we should checknumberOfNodes
early, which would be an improvement tohashTableStartDo(),
hashTableForEachDo()`, and possibly other hash table functions.FYI: @keithc-ca
The text was updated successfully, but these errors were encountered: