Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the hashtable related code by checking the node count #211

Closed
ChengJin01 opened this issue Jul 15, 2024 · 2 comments
Closed

Improve the hashtable related code by checking the node count #211

ChengJin01 opened this issue Jul 15, 2024 · 2 comments

Comments

@ChengJin01
Copy link

The issue was detected when adjusting the thunk heap related code via eclipse-openj9/openj9#19852, in which we found that the code in hashTableForEachDo() still relies on the node count to determine whether to move forward to check the hashtable but there are still a bunch of code/assignments before returning null for a empty hashtable. Instead, we should check numberOfNodes early, which would be an improvement to hashTableStartDo(), hashTableForEachDo()`, and possibly other hash table functions.

FYI: @keithc-ca

@keithc-ca
Copy link
Contributor

This should instead be proposed at https://github.com/eclipse/omr.

@ChengJin01
Copy link
Author

Created at eclipse/omr#7408.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants