Skip to content

Commit d6b1825

Browse files
authored
Merge pull request #1310 from clalancette/clalancette/fix-cmake-3.23-warning
Fix warning when building with CMake 3.23.
2 parents 3f5cf85 + cbd079f commit d6b1825

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

iceoryx_posh/cmake/cpptoml/CMakeLists.txt

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,6 @@ else()
3333
set(CREATE_PATH_COMMAND mkdir -p)
3434
endif()
3535

36-
if(DEFINED CMAKE_TOOLCHAIN_FILE)
37-
set(TOOLCHAIN_FILE "-DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}")
38-
set(cpptoml_DIR ${CMAKE_BINARY_DIR}/dependencies/install/lib/cmake/cpptoml)
39-
set(cpptoml_DIR ${cpptoml_DIR} CACHE PATH "" FORCE)
40-
endif()
41-
4236
# set download config, source and build paths
4337
set(DOWNLOAD_CONFIG_DIR ${CMAKE_BINARY_DIR}/dependencies/cpptoml/download)
4438
set(SOURCE_DIR ${CMAKE_BINARY_DIR}/dependencies/cpptoml/src)
@@ -72,14 +66,22 @@ if(result)
7266
message(WARNING "CMake step [patch] for cpptoml failed: ${result}! Build of cpptoml might fail")
7367
endif()
7468

75-
execute_process(COMMAND ${CMAKE_COMMAND} -G "${CMAKE_GENERATOR}" "-DENABLE_LIBCXX=off" "-DCPPTOML_BUILD_EXAMPLES=off" "-DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}" "${TOOLCHAIN_FILE}" "${SOURCE_DIR}"
76-
"-DCMAKE_C_FLAGS_INIT=${CMAKE_C_FLAGS_INIT}"
77-
"-DCMAKE_CXX_FLAGS_INIT=${CMAKE_CXX_FLAGS_INIT}"
78-
"-DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}"
79-
"-DCMAKE_C_COMPILER_TARGET=${CMAKE_C_COMPILER_TARGET}"
80-
"-DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}"
81-
"-DCMAKE_CXX_COMPILER_TARGET=${CMAKE_CXX_COMPILER_TARGET}"
82-
"-DCMAKE_LINKER=${CMAKE_LINKER}"
69+
set(CMAKE_ADDITIONAL_OPTIONS
70+
"-DCMAKE_C_FLAGS_INIT=${CMAKE_C_FLAGS_INIT}"
71+
"-DCMAKE_CXX_FLAGS_INIT=${CMAKE_CXX_FLAGS_INIT}"
72+
"-DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}"
73+
"-DCMAKE_C_COMPILER_TARGET=${CMAKE_C_COMPILER_TARGET}"
74+
"-DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}"
75+
"-DCMAKE_CXX_COMPILER_TARGET=${CMAKE_CXX_COMPILER_TARGET}"
76+
"-DCMAKE_LINKER=${CMAKE_LINKER}")
77+
78+
if(DEFINED CMAKE_TOOLCHAIN_FILE)
79+
list(APPEND CMAKE_ADDITIONAL_OPTIONS "-DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}")
80+
set(cpptoml_DIR ${CMAKE_BINARY_DIR}/dependencies/install/lib/cmake/cpptoml)
81+
set(cpptoml_DIR ${cpptoml_DIR} CACHE PATH "" FORCE)
82+
endif()
83+
84+
execute_process(COMMAND ${CMAKE_COMMAND} -G "${CMAKE_GENERATOR}" "-DENABLE_LIBCXX=off" "-DCPPTOML_BUILD_EXAMPLES=off" "-DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}" "${SOURCE_DIR}" ${CMAKE_ADDITIONAL_OPTIONS}
8385
RESULT_VARIABLE result
8486
WORKING_DIRECTORY ${BUILD_DIR} )
8587
if(result)

0 commit comments

Comments
 (0)