Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iox-#2 Integrate iceoryx v3.0 release #6

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

iox-#2 Integrate iceoryx v3.0 release #6

wants to merge 1 commit into from

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Aug 8, 2022 •
edited
Loading

Preparations for iceoryx v3.0 release, not to be merged soon

Todo

  • Use new CMake macros

Pre-Review Checklist for the PR Author

  1. Code is formatted with clang-format
  2. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  3. Relevant issues are linked
  4. Add sensible notes for the reviewer
  5. All checks have passed
  6. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

mossmaurice
mossmaurice commented Aug 8, 2022
View reviewed changes
CMakeLists.txt
include(FetchContent)
FetchContent_Declare(
iceoryx
GIT_REPOSITORY https://github.com/eclipse-iceoryx/iceoryx.git
GIT_TAG v2.0.2
GIT_TAG be2272fee0b25ce203fa63cc3a93a740baaa4c73
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change this line to v3.0.0 before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use iox_add_excutable once iceoryx v3 is release
1 participant
@mossmaurice