Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An Eplan PDF file is not committed correctly #66

Open
ssi-mab opened this issue Dec 6, 2024 · 3 comments
Open

An Eplan PDF file is not committed correctly #66

ssi-mab opened this issue Dec 6, 2024 · 3 comments
Labels
bug Something isn't working need info Waiting for more information

Comments

@ssi-mab
Copy link

ssi-mab commented Dec 6, 2024

Version

7.0.0.202409031743-r

Operating System

Windows

Eclipse version

2024-09

Bug description

An Eplan PDF file is not committed correctly. The file has a size of 33,0 MB (34 663 079 Bytes). After committing, deleting and replacing it with head revision the file has a size of 33,9 MB (35 551 101 Bytes). If another user clones a repository the PDF file has the invalid size as well.

This bug does not occur if the file is committed via Git Bash.

How To Reproduce

A

  1. Commit Eplan PDF file
  2. Delete Eplan PDF file
  3. Replace the file with the head revision

B

  1. Commit Eplan PDF file
  2. Push
  3. Clone repository

Unfortunately, I cannot share this file. However, I will try to create a dummy PDF file to share.

Actual behavior

No stack trace or logging

Expected behavior

File is committed correctly and it can be restored or checked out correctly.

Relevant log output

-

Other information

No response

@ssi-mab ssi-mab added the bug Something isn't working label Dec 6, 2024
@tomaswolf
Copy link
Contributor

Yes, please provide a sample PDF file that shows this behavior.

I suspect it's JGit inadvertently treating the file as non-binary. Try marking it as binary explicitly via .gitattributes.

@tomaswolf tomaswolf added the need info Waiting for more information label Dec 12, 2024
@ssi-mab
Copy link
Author

ssi-mab commented Dec 12, 2024

Marking it as binary explicitly via .gitattributes does not produce the error. Thank you.

@tomaswolf
Copy link
Contributor

It would still be cool if you could provide a PDF that reproduces the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need info Waiting for more information
Projects
None yet
Development

No branches or pull requests

2 participants