Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing order by on nextNotLeased in stateful entity store (SQL) #4308

Closed
wolf4ood opened this issue Jun 27, 2024 · 0 comments · Fixed by #4316
Closed

Missing order by on nextNotLeased in stateful entity store (SQL) #4308

wolf4ood opened this issue Jun 27, 2024 · 0 comments · Fixed by #4316
Assignees
Labels
bug Something isn't working

Comments

@wolf4ood
Copy link
Contributor

wolf4ood commented Jun 27, 2024

Bug Report

Describe the Bug

Implementations of SQL variant StateEntityStore for the nextNotLeased method miss the order by
when looking for the next items to process. This could lead to starvation for some state and it could
prevent some optimization (index creation) when fetching the items to process.

Observed Behavior

For example putting an index like this

CREATE INDEX IF NOT EXISTS transfer_process_state
    ON edc_transfer_process (state);

Makes the NextNotLeased.avoidsStarvation on TransferProcessStoreTestBase fails

Possible Implementation

add order by state_time_stamp on QuerySpec in all nextNotLeased SQL implementation

@wolf4ood wolf4ood added the bug Something isn't working label Jun 27, 2024
@wolf4ood wolf4ood self-assigned this Jun 27, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Jun 27, 2024
@wolf4ood wolf4ood removed the triage all new issues awaiting classification label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant