Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Failed to run tests with EdcRuntimeExtension on Windows OS #4285

Closed
ieuna opened this issue Jun 19, 2024 · 4 comments
Closed

Bug: Failed to run tests with EdcRuntimeExtension on Windows OS #4285

ieuna opened this issue Jun 19, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ieuna
Copy link

ieuna commented Jun 19, 2024

Bug Report

Describe the Bug

Passing 0 argument to "modules"(type: varagrs) parameter to EdcRuntimeExtension constructor results in failed tests on Windows OS. EdcRuntimeExtension fails to resolve class path on Windows.
It works on Linux.
image

Expected Behavior

Passing no arguments to "modules" parameter to EdcRuntimeExtension constructor should not cause any issue on Windows OS since the argument type is varargs.

Observed Behavior

Failed tests:
image

StackTrace:
StackTrace

Passing an empty string to "modules" parameter fixes the problem on Windows.

Steps to Reproduce

Steps to reproduce the behavior:

  1. While creating EDCRuntimeExtension, do not pass third parameter.
@RegisterExtension
EdcRuntimeExtension RUNTIME = new EdcRuntimeExtension(
		"name",
		Map.of(....)
);
  1. Run tests with gradle on Windows:
    ./gradlew clean test
  2. See test report

Context Information

  • EDC version- 0.7.0
  • OS: Windows
  • Java version- 21
  • Gradle- 8.6

Detailed Description

Tests are not running because EdcRuntimeExtension fails to read class path if "modules" is an empty array.
image

@github-actions github-actions bot added the triage all new issues awaiting classification label Jun 19, 2024
Copy link

Thanks for your contribution 🔥 We will take a look asap 🚀

@paullatzelsperger paullatzelsperger removed the triage all new issues awaiting classification label Jun 26, 2024
@paullatzelsperger
Copy link
Member

paullatzelsperger commented Jun 26, 2024

@ieuna We don't support native Windows as base OS, typically what people do is run the tests on WSL, or a linux VM. MacOS works too. Its not likely we'll spend time on this.

You're welcome to contribute a fix (that doesn't break stuff anywhere else!) though.

@paullatzelsperger paullatzelsperger added bug_report Suspected bugs, awaiting triage good first issue Good for newcomers enhancement New feature or request and removed bug_report Suspected bugs, awaiting triage labels Jun 26, 2024
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Jul 11, 2024
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2024
@github-actions github-actions bot removed the stale Open for x days with no activity label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants