Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: control api context api #4259

Closed
ndr-brt opened this issue Jun 11, 2024 · 0 comments · Fixed by #4276
Closed

refactor: control api context api #4259

ndr-brt opened this issue Jun 11, 2024 · 0 comments · Fixed by #4276
Labels
refactoring Cleaning up code and dependencies

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Jun 11, 2024

Feature Request

Currently we have different classes that implement pretty much the same base logic to interact with a control endpoint:

  • DataPlaneSignalingClient
  • TransferProcessHttpClient
  • RemoteDataPlaneSelectorService
  • RemoteDataPlaneClient

these classes represent service in a remote way, and they "should" be an implementation of the Service implementation (like RemoteDataPlaneSelectorService is currently). This way the abstraction will be better understandable (e.g.: use "embed" service implementation when it is registered in the runtime, use "remote" implementation otherwise)

Extracting an http client wrapper that provides out of the box authentication, response codes handling and eventual error parsing (note that all the EDC apis return a list of ApiErrorDetail in case of error) will remove duplication and will make new remote services implementation easier to do.

Which Areas Would Be Affected?

remote services

Why Is the Feature Desired?

design

Solution Proposal

If possible, provide a (brief!) solution proposal.

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Jun 11, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Jun 11, 2024
@paullatzelsperger paullatzelsperger removed the triage all new issues awaiting classification label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants