TitaniumJsonLd context caching loads document on every call

[ricardas-buc]

Bug Report

Describe the Bug

A mixup of orElse VS orElseGet causes document to be loaded every time, even though cache is being hit.

Connector/core/common/lib/json-ld-lib/src/main/java/org/eclipse/edc/jsonld/TitaniumJsonLd.java

Lines 199 to 200 in 564d627

	return Optional.ofNullable(documentCache.get(uri))
	.orElse(loader.loadDocument(uri, options));

Expected Behavior

Cached document should not be loaded again.

Context Information

• Used version EDC 0.7

Detailed Description

If applicable, add screenshots and logs to help explain your problem.

Possible Implementation

Switching to orElseGet solves the issue. This does save extra 2-5ms per execution.

[ndr-brt]

thanks for reporting, would you like to provide a PR to implement this enhancement? (definitely not a bug)

[ricardas-buc]

I would not agree that it is not a bug, document cache is not being properly utilized :) In any case it should be a simple fix:

            var document = Optional.ofNullable(documentCache.get(uri));
            if (document.isEmpty()) {
                return loader.loadDocument(uri, options);
            }
            return document.get();

using orElseGet would require additional code to handle JsonLdError exception, but this way it is rather straightforward. If PR is still required, then this will have to wait, not enough resources on my end for it to happen this week.

[ndr-brt]

@ricardas-buc no worries, a PR has been already opened for this enhancement