-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate entry for participantId in the CatalogResponse #4231
Comments
hey, there's a specific policy for deprecations cleanup, and we do that after every "milestone" release, so this cleanup will happen in a pair of milestones or so. |
Any hint where that policy can be found? Just let me know whenever there can be something done from our side. |
this was never been carved into a DR, given that we're still in a "incubating" phase, we currently do not support older versions generally (https://github.com/eclipse-edc/docs/blob/main/developer/releases.md#towards-a-first-release), the deprecation thing is just an helper for the users to get the new versions in a smoother way. |
discussed in Technical Committee Meeting on June 12, 2024: no need for action, as this field will be removed in subsequent cleanups. Will close this issue. |
Feature Request
Which Areas Would Be Affected?
CatalogResponse -> CatalogProtocolServiceImpl
Why Is the Feature Desired?
Actually there are duplicates of the participantId present in the catalogResponse.
Option 2 is marked as deprecated since "0.5.1" so cleanup the participantId from the properties might be a good option.
Solution Proposal
Small refactoring to remove the deprecated field to go with the participantId coming from dspace context.
At the same time i am volunteering for providing the PR to fix this.
The text was updated successfully, but these errors were encountered: