Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate entry for participantId in the CatalogResponse #4231

Closed
domreuter opened this issue Jun 4, 2024 · 4 comments
Closed

Duplicate entry for participantId in the CatalogResponse #4231

domreuter opened this issue Jun 4, 2024 · 4 comments
Labels
refactoring Cleaning up code and dependencies

Comments

@domreuter
Copy link
Contributor

Feature Request

Which Areas Would Be Affected?

CatalogResponse -> CatalogProtocolServiceImpl

Why Is the Feature Desired?

Actually there are duplicates of the participantId present in the catalogResponse.

  1. "dspace:participantId": "BPNPROVIDER" which expands to "https://w3id.org/dspace/v0.8/participantId": "ProviderId"
  2. "participantId": "BPNPROVIDER" which expands to "https://w3id.org/edc/v0.0.1/ns/participantId": "ProviderId"

Option 2 is marked as deprecated since "0.5.1" so cleanup the participantId from the properties might be a good option.

Solution Proposal

Small refactoring to remove the deprecated field to go with the participantId coming from dspace context.

At the same time i am volunteering for providing the PR to fix this.

@github-actions github-actions bot added the triage all new issues awaiting classification label Jun 4, 2024
@ndr-brt
Copy link
Member

ndr-brt commented Jun 4, 2024

hey, there's a specific policy for deprecations cleanup, and we do that after every "milestone" release, so this cleanup will happen in a pair of milestones or so.

@domreuter
Copy link
Contributor Author

Any hint where that policy can be found?

Just let me know whenever there can be something done from our side.

@ndr-brt
Copy link
Member

ndr-brt commented Jun 4, 2024

this was never been carved into a DR, given that we're still in a "incubating" phase, we currently do not support older versions generally (https://github.com/eclipse-edc/docs/blob/main/developer/releases.md#towards-a-first-release), the deprecation thing is just an helper for the users to get the new versions in a smoother way.
In this case, given that we are referring to the DSP apis (that are not under our control but we're implementing existing specs) we could just drop that field, but keeping a deprecation for some months doesn't cost anything, so...

@paullatzelsperger paullatzelsperger added refactoring Cleaning up code and dependencies and removed triage all new issues awaiting classification labels Jun 12, 2024
@paullatzelsperger
Copy link
Member

discussed in Technical Committee Meeting on June 12, 2024: no need for action, as this field will be removed in subsequent cleanups. Will close this issue.

@paullatzelsperger paullatzelsperger closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

No branches or pull requests

3 participants