Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename providerUrl and connectorAddress to counterPartyAddress on management api #3343

Closed
ndr-brt opened this issue Jul 31, 2023 · 1 comment · Fixed by #3597
Closed

rename providerUrl and connectorAddress to counterPartyAddress on management api #3343

ndr-brt opened this issue Jul 31, 2023 · 1 comment · Fixed by #3597
Assignees
@saschaisele-zf
Labels
api Feature related to the (REST) api refactoring Cleaning up code and dependencies
Milestone
Milestone 12

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Jul 31, 2023 •
edited by paullatzelsperger
Loading

Feature Request

Currently there are multiple way of calling the same field: counterPartyAddress as it was called in the internal domain model (RemoteMessage included) is also called providerUrl and connectorAddress.

Which Areas Would Be Affected?

management api

Why Is the Feature Desired?

consistency

Solution Proposal

we should need to avoid breaking changes, printing a log in the case the old name is used, as done in #3342
@ndr-brt ndr-brt added refactoring Cleaning up code and dependencies api Feature related to the (REST) api labels Jul 31, 2023
@ndr-brt ndr-brt added this to the Milestone 11 milestone Jul 31, 2023
@ndr-brt ndr-brt mentioned this issue Jul 31, 2023
Merged
@saschaisele-zf
Copy link
Contributor

saschaisele-zf commented Oct 26, 2023 •
edited
Loading

Will start working on this issue next.
@ndr-brt you can assign me here.

saschaisele-zf added a commit to saschaisele-zf/EDC-Connector that referenced this issue Nov 10, 2023
@saschaisele-zf
refactor(management-api): counterPartyAddress (eclipse-edc#3343)
db869c0 
Signed-off-by: Sascha Isele <[email protected]>
saschaisele-zf added a commit to saschaisele-zf/EDC-Connector that referenced this issue Nov 10, 2023
@saschaisele-zf
refactor(management-api): counterPartyAddress (eclipse-edc#3343)
26ed509 
Signed-off-by: Sascha Isele <[email protected]>
@saschaisele-zf saschaisele-zf mentioned this issue Nov 10, 2023
Merged
ndr-brt pushed a commit that referenced this issue Nov 16, 2023
@saschaisele-zf
refactor(api): counterPartyAddress (#3597)
dd99058 
* refactor(management-api): counterPartyAddress (#3343)

Signed-off-by: Sascha Isele <[email protected]>

* checkstyle fix

Signed-off-by: Sascha Isele <[email protected]>

* review suggestions and checkstyle

Signed-off-by: Sascha Isele <[email protected]>

* moved deprecation warning to validators

Signed-off-by: Sascha Isele <[email protected]>

* added tests checking for deprecation warning in validators

Signed-off-by: Sascha Isele <[email protected]>

---------

Signed-off-by: Sascha Isele <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saschaisele-zf saschaisele-zf

Labels
api Feature related to the (REST) api refactoring Cleaning up code and dependencies
Projects
None yet
Milestone
Milestone 12
Development

Successfully merging a pull request may close this issue.

refactor(api): counterPartyAddress saschaisele-zf/EDC-Connector
3 participants
@ndr-brt @paullatzelsperger @saschaisele-zf