Support for Returning the Response-Body of Unsuccessful (>= 300) Requests

[efiege]

Currently the HttpDataSource won't forward the request-body from the source, if the http status code is not in the [200..300) range.

However also responses with greater status codes may contain valid response bodys, that are relevant for the consumer.

Is it feasible to also return those response bodies?

Here you can see the current implementation:

Connector/extensions/data-plane/data-plane-http/src/main/java/org/eclipse/edc/connector/dataplane/http/pipeline/HttpDataSource.java

Lines 63 to 88 in 8932966

	if (response.isSuccessful()) {
	var body = response.body();
	if (body == null) {
	throw new EdcException(format("Received empty response body transferring HTTP data for request %s: %s", requestId, response.code()));
	}
	var stream = body.byteStream();
	responseBodyStream.set(new ResponseBodyStream(body, stream));
	var mediaType = Optional.ofNullable(body.contentType()).map(MediaType::toString).orElse(OCTET_STREAM);
	return success(Stream.of(new HttpPart(name, stream, mediaType)));
	} else {
	try {
	if (NOT_AUTHORIZED == response.code() || FORBIDDEN == response.code()) {
	return StreamResult.notAuthorized();
	} else if (NOT_FOUND == response.code()) {
	return StreamResult.notFound();
	} else {
	return error(format("Received code transferring HTTP data: %s - %s.", response.code(), response.message()));
	}
	} finally {
	try {
	response.close();
	} catch (Exception e) {
	monitor.info("Error closing failed response", e);
	}
	}
	}

[jimmarino]

It should not forward the body as this may inadvertently expose internal details of a back-end connection.