Revert "restrict access to encrypted odaPassword from java script" (#2258)

Author: DaniEll-AT

data/org.eclipse.birt.report.engine.script.javascript/src/org/eclipse/birt/report/engine/javascript/JavascriptEngine.java

@@ -32,7 +32,6 @@
 import org.eclipse.birt.core.script.ScriptContext;
 import org.eclipse.birt.core.script.functionservice.IScriptFunctionContext;
 import org.eclipse.birt.data.engine.api.IDataScriptEngine;
-import org.eclipse.birt.report.model.core.JavaScriptExecutionStatus;
 import org.mozilla.javascript.Context;
 import org.mozilla.javascript.ImporterTopLevel;
 import org.mozilla.javascript.LazilyLoadedCtor;
@@ -249,7 +248,6 @@ public Object evaluate(ScriptContext scriptContext, ICompiledScript compiledScri
 		// String source = ( (CompiledJavascript) compiledScript )
 		// .getScriptText( );
 		try {
-			JavaScriptExecutionStatus.setExeucting(true);
 			Script script = ((CompiledJavascript) compiledScript).getCompiledScript();
 			Object value = script.exec(context, getJSScope(scriptContext));
 			return jsToJava(value);
@@ -259,8 +257,6 @@ public Object evaluate(ScriptContext scriptContext, ICompiledScript compiledScri
 			// ResourceConstants.JAVASCRIPT_COMMON_ERROR,
 			// new Object[]{source, e.getMessage( )}, e );
 			throw new CoreException(ResourceConstants.INVALID_EXPRESSION, e.getMessage(), e);
-		} finally {
-			JavaScriptExecutionStatus.remove();
 		}
 	}
 

model/org.eclipse.birt.report.model/src/org/eclipse/birt/report/model/core/DesignElement.java

@@ -530,8 +530,6 @@ public abstract class DesignElement implements IDesignElement, IPropertySet, IDe
 	 */
 	private static final int MAX_DISPLAY_LABEL_LEN = 30;
 
-	private static final String ODA_PASSWORD = "odaPassword";
-
 	/**
 	 * Elements have an optional name. The name may be required by some element
 	 * types. If so, the derived element class should enforce the use of the name.
@@ -956,12 +954,6 @@ public Object getProperty(Module module, String propName) {
 			return null;
 		}
 
-		if (ODA_PASSWORD.contentEquals(propName) && prop.isEncryptable() && getEncryptionID(prop) != null
-				&& JavaScriptExecutionStatus.isExecuting()) {
-			// throw new RuntimeException("Invalid operation: Can not access encrypted password from script");
-			return null;
-		}
-
 		return getProperty(module, prop);
 	}