Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect parameter for SerialFlashUnknownJedec #23

Open
addinh opened this issue Jun 11, 2021 · 0 comments
Open

Incorrect parameter for SerialFlashUnknownJedec #23

addinh opened this issue Jun 11, 2021 · 0 comments

Comments

@addinh
Copy link

addinh commented Jun 11, 2021

SerialFlashUnknownJedec constructor expects a bytes-like parameter jedec (since it is passed in hexlify()), however in some places a str is passed into the constructor instead (lines 227 and 249 of pyspiflash/serialflash.py):

raise SerialFlashUnknownJedec("Unable to read JEDEC Id")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@addinh