ADR Suggestion: DescriptorArray #95
Closed
henrikjacobsenfys
started this conversation in
Ideas
Replies: 2 comments
-
I think this is all correct but should be converted to a task in the EasyScience project https://github.com/orgs/EasyScience/projects/21 New features, especially extensions of existing functionality are best described on the project board as they are then easy to manage in the workflow TODO -> IN PROGRESS -> DONE |
Beta Was this translation helpful? Give feedback.
0 replies
-
We will also allow addition etc. with DescriptorNumbers |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
For EasyCrystallography and EasyDiffraction, we need to have Descriptors that are arrays. We agreed that it should be named DescriptorArray.
It will inherit from DescriptorBase, and will be implemented as scipp variables using scipp.array.
It will have all the same methods as DescriptorNumbers, including element wise+,-abs, neg.
We will follow numpy conventions. This means that * and / can only be done with Numbers or DescriptorNumbers, and will be element wise.
Matrix multiplication and division will be implemented as well, using Numpy. We will follow the Numpy naming scheme. Numpy Arrays and DescriptorArrays will be accepted inputs.
Beta Was this translation helpful? Give feedback.
All reactions