Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DescriptorArray #96

Open
henrikjacobsenfys opened this issue Jan 20, 2025 · 0 comments
Open

Implement DescriptorArray #96

henrikjacobsenfys opened this issue Jan 20, 2025 · 0 comments

Comments

@henrikjacobsenfys
Copy link
Member

henrikjacobsenfys commented Jan 20, 2025

For EasyCrystallography and EasyDiffraction, we need to have Descriptors that are arrays. We agreed that it should be named DescriptorArray.

It will inherit from DescriptorBase, and will be implemented as scipp variables using scipp.array.

It will have all the same methods as DescriptorNumbers, including element wise+,-abs, neg.

We will follow numpy conventions. This means that * and / can only be done with Numbers or DescriptorNumbers, and will be element wise.

Matrix multiplication and division will be implemented as well, using Numpy. We will follow the Numpy naming scheme. Numpy Arrays and DescriptorArrays will be accepted inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant