Cannot disable logstream (in the obvious way)

[rrjjvv]

What went wrong?

While trying to diagnose #4063, I was unable to disable logstream via earthly --logstream=false as I would expect.

I realize this is a hidden flag, thus "unsupported", and may be more of a UX thing than a true bug.

What should have happened?

The workaround is to use earthly --logstream=false --logstream-upload=false.

earthly/cmd/earthly/app/before.go

Lines 46 to 48 in 37134bf

	if app.BaseCLI.Flags().LogstreamUpload {
	app.BaseCLI.Flags().Logstream = true
	}

I think the 'problem' is that the booleans don't allow a distinction of set vs. unset. It makes sense that uploads requires the local functionality to be enabled... when I want uploads. I didn't request uploads though; the default value for uploads shouldn't trump my explicit request to disable.

Ideally, in pseudocode, it would be something like:

LogstreamUpload := LogstreamUpload && (LogstreamUploadWasSet || (! Logstream && LogstreamWasSet))
// existing code

In other words, enable upload (thus local) if the user explicitly asked for it, or if the user did not explicitly opt-out of local.

I'm not knowledgeable about logstream, neither what it really does, or the relationship between those two modes; the proper solution may be more nuanced that just distinguishing between values that came from defaults vs. from users. I just know that logstream is a cause or contributor to #4063 and it was confusing why my initial attempts to disable it did not work.

It actually looks like you may have run into this as well in 5812dec#diff-f9982f795fe7027eb275c129ce300d01d3eeacfe77549152a9ab23cb8e18c95b, but I can't tell if that was a workaround for this 'bug', or if you consider this 'bug' a feature...

What earthly version?

This is in 0.8.9 and probably every version going back to 0.7.19

Buildkit Logs

No response

Other Helpful Information

No response