Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE is not packed in source distribution #663

Open
jhamman opened this issue Feb 1, 2025 · 1 comment
Open

LICENSE is not packed in source distribution #663

jhamman opened this issue Feb 1, 2025 · 1 comment

Comments

@jhamman
Copy link
Member

jhamman commented Feb 1, 2025

Looking at the source distribution of our latest release, I'm not seeing the LICENSE file:

❯ tree ~/Downloads/icechunk-0.1.0 -L 2
/Users/jhamman/Downloads/icechunk-0.1.0
├── PKG-INFO
├── icechunk
│   ├── Cargo.toml
│   ├── examples
│   ├── proptest-regressions
│   ├── src
│   └── tests
├── icechunk-python
│   ├── Cargo.lock
│   ├── Cargo.toml
│   ├── benchmarks
│   ├── examples
│   ├── notebooks
│   ├── python
│   ├── src
│   └── tests
├── pyproject.toml
└── python
    └── icechunk

We probably need to change something in pyroject.toml to make this work.

@mpiannucci
Copy link
Contributor

We specify it by name in pyproject. We currently only have the license file in the root directory which cannot be packaged because its in a parent directory. Prob need a symlink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants