Merge pull request crs4#64 from kikkomep/fix/issue-61

fix: trailing slash for Directory Data Entities is RECOMMENDED but not mandatory

Author: kikkomep

rocrate_validator/profiles/ro-crate/must/4_data_entity_metadata.ttl

@@ -141,19 +141,6 @@ ro-crate:DataEntityRquiredPropertiesShape a sh:NodeShape ;
             # sh:message "A Data Entity MUST be directly or indirectly linked to the `Root Data Entity` through the `hasPart` property" ;
         ] .
 
-ro-crate:DirectoryDataEntityRequiredValueRestriction a sh:NodeShape ;
-    sh:name "Directory Data Entity: REQUIRED value restriction" ;
-    sh:description """A Directory Data Entity MUST end with `/`""" ;
-    sh:targetNode ro-crate:Directory ;
-    sh:property [
-        a sh:PropertyShape ;
-        sh:name "Directory Data Entity: REQUIRED value restriction" ;
-        sh:description """Check if the Directory Data Entity ends with `/`""" ;
-        sh:path [ sh:inversePath rdf:type ] ;
-        sh:message """Every Data Entity Directory URI MUST end with `/`""" ;
-        sh:pattern "/$" ;
-    ] .
-
 ro-crate:GenericDataEntityRequiredProperties a sh:NodeShape ;
     sh:name "Generic Data Entity: REQUIRED properties" ;
     sh:description """A Data Entity other than a File or a Directory MUST be a `DataEntity`""" ;

rocrate_validator/profiles/ro-crate/should/4_data_entity_metadata.ttl

@@ -54,3 +54,16 @@ ro-crate:FileRecommendedProperties a sh:NodeShape ;
             ]
         )
     ] .
+
+ro-crate:DirectoryDataEntityRequiredValueRestriction a sh:NodeShape ;
+    sh:name "Directory Data Entity: RECOMMENDED value restriction" ;
+    sh:description """A Directory Data Entity SHOULD end with `/`""" ;
+    sh:targetNode ro-crate:Directory ;
+    sh:property [
+        a sh:PropertyShape ;
+        sh:name "Directory Data Entity: RECOMMENDED value restriction" ;
+        sh:description """Check if the Directory Data Entity ends with `/`""" ;
+        sh:path [ sh:inversePath rdf:type ] ;
+        sh:message """Every Data Entity Directory URI SHOULD end with `/`""" ;
+        sh:pattern "/$" ;
+    ] .

tests/integration/profiles/ro-crate/test_data_entity_metadata.py

@@ -59,10 +59,10 @@ def test_directory_data_entity_wo_trailing_slash():
     """Test a RO-Crate without a root data entity."""
     do_entity_test(
         paths.directory_data_entity_wo_trailing_slash,
-        models.Severity.REQUIRED,
+        models.Severity.RECOMMENDED,
         False,
-        ["Directory Data Entity: REQUIRED value restriction"],
-        ["Every Data Entity Directory URI MUST end with `/`"]
+        ["Directory Data Entity: RECOMMENDED value restriction"],
+        ["Every Data Entity Directory URI SHOULD end with `/`"]
     )