Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightbox dialog: Title should wrap instead of using ellipses #2333

Closed
1 task done
LuLaValva opened this issue May 9, 2024 · 2 comments · Fixed by #2334
Closed
1 task done

lightbox dialog: Title should wrap instead of using ellipses #2333

LuLaValva opened this issue May 9, 2024 · 2 comments · Fixed by #2334

Comments

@LuLaValva
Copy link
Member

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

Text in the title of lightbox dialog is truncated with ellipses instead of wrapping

Expected behavior

Title text should wrap

Skin version

17.4.1

Device/OS/Browser info

All devices & browsers

Steps to reproduce

Create lightbox dialog with header longer than screen width

Relevant code block

No response

Additional context

Text wrap was the initial behavior for this component, but there was a push from design systems team to truncate with ellipses instead. This should not have been approved because, especially after internationalization, there are likely to be cases where the title is impossible to read for some users.

Even in the worst case with text wrapping, the body will still be visible:

image

Screen.Recording.2024-05-09.at.2.10.53.PM.mov

As such, title should be reverted back from truncation to wrapping.

@randybascue
Copy link

Agreed. Let's revert to wrapping. We'll update on our end as well

@ArtBlue
Copy link
Contributor

ArtBlue commented May 10, 2024

Excellent! Thanks, @randybascue !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants