Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Account for disabled state #2319

Open
5 of 6 tasks
randybascue opened this issue Apr 26, 2024 · 1 comment
Open
5 of 6 tasks

Image: Account for disabled state #2319

randybascue opened this issue Apr 26, 2024 · 1 comment

Comments

@randybascue
Copy link

randybascue commented Apr 26, 2024

Description

Problem

There are situations where an image is interactive but disabled, or nested within an element that is disabled. This is not currently accounted for within the system.

Solution

Add a disabled treatment for images to further reinforce its state that desaturates and reduces its opacity.

Specifications

Opacity = 0.32 or 32%
Adjustment layer = Desaturation

We can add a token for the opacity called opacity.interactive.disabled?

Acceptance criteria

A disabled state treatment is available in production that desaturates the image and reduces its opacity.

Notes

This was discussed in a previous issue.

Screenshots

image

Figma link

No response

Engineering pre-requisites

  • Successful design review with Design System Team.
  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
  • Successful accessibility review with Core A11Y Team.
  • Successful frontend review with eBayUI Team.
@randybascue randybascue changed the title Image: Account for disabled staate Image: Account for disabled state Apr 26, 2024
@agliga
Copy link
Contributor

agliga commented May 21, 2024

Probably will add either a token for this, or an image-disabled class in util.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants