Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon-button: refactor module and remove overrides in other modules #2295

Open
1 task done
ArtBlue opened this issue Mar 19, 2024 · 1 comment
Open
1 task done

icon-button: refactor module and remove overrides in other modules #2295

ArtBlue opened this issue Mar 19, 2024 · 1 comment
Milestone

Comments

@ArtBlue
Copy link
Contributor

ArtBlue commented Mar 19, 2024

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

icon-button currently has a negative outline-offset: outline-offset: -10px;...

image

The modules that use it have to resort to creating overrides to utilize it properly.

image

Expected behavior

Ideally, there should be no negative offset and except in the rarest of cases. Modules should be able to use icon-button with its modifiers to achieve the desired effect.

Skin version

17.3.0

Device/OS/Browser info

(all)

Steps to reproduce

1. (See details)

Relevant code block

  1. Investigate why the negative offset was added in the first place and understand the intent. The negative offset may be needed elsewhere for a more specific use. If so, move it and scope it inside only where needed, if at all.
  2. Remote the negative offset.
  3. Remove the overrides in other modules that use icon-button and see how they each look.
  4. Make small adjustments as needed in each module.

Additional context

No response

@agliga
Copy link
Contributor

agliga commented Apr 22, 2024

We need to remove all custom outline offsets and then for transparent modifier to add a custom outline offset so it does not focus on the padding/border area but directly on the icon.

@agliga agliga added this to the 17.5.0 milestone Apr 29, 2024
@agliga agliga modified the milestones: 17.5.0, 18.0.0, 18.1.0 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants