ebay-listbox-button: keyboard focus issue after shift-tabbing back to button from listbox

[ianmcburnie]

Bug Report

eBayUI Version: 10.x

Description

1. Goto: https://opensource.ebay.com/ebayui-core/?path=/story/buttons-ebay-listbox-button--default
2. Set keyboard focus on button
3. Press ENTER or SPACEBAR
4. Press SHIFT+TAB
5. Press TAB

Result: listbox collapses, and focus moves to next focusable element on page.
Expected: focus returns to listbox.

I think we just need to change the listbox to have tabindex=0 when in expanded state, rather than tabindex=-1, as in this example: https://makeup.github.io/makeup-js/makeup-listbox-button/index.html

Workaround

Yes. Move focus back to button and press ENTER or SPACEBAR again to re-open listbox.

[agliga]

This might be an issue with makeup-expander.
I switched the tabindex to 0 in the code but expander is switching it to -1
https://github.com/makeup/makeup-js/blob/master/packages/makeup-expander/src/index.js#L89-L92
We might have to change the focusManagament.

[saiponnada]

Currently when we shift tab from the listbox or menu item back to the button, the overlay stays open. I believe this was by design originally, but in retrospect I think it would probably make more sense if the overlay collapses (and can then easily be opened by SPACEBAR/ENTER again).

There is currently an issue open on makeup that will resolve this issue.

[saiponnada]

Fixed this issue in v15.0.0. Ref: dc6aa3f