-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ideal transformers to impedances #260
Comments
I have created the pull request, with this it might be clearer what I have in mind. If you consider this addition there are some open points which have to be discussed before merging:
|
Yes this exists in PowerFactory as well. In PowerFactory it is a tap ratio, not vn1_kv & vn2_kv.
Not sure also, would have to look into it. Is there a reason it is from_bus and not to_bus or just by convention?
Yes it should also be possible to read the voltage value directly from the ppc, so that the pandas table ist not changed and it is also more performant (using numpy instead of pandas).
If we decide to use a tap_ratio instead of vn1/vn2 it could just default to 1, whereas having vn1/v2 doesn't really have a logical default. If there is no significant advantage in specifically definining vn1/vn2, I would preferr this over having some case by case distinction. |
I think it is just by convention, but I don't know.
I am sure it is possible and I will change that.
I think the only reason for vn1/vn2 is to have it consistent with real transformers. That does not seem to be a significant advantage, so I will use tap_ratio instead. |
I have updated the implementation to use tap_ratio as parameter. One still open question is, on which side of the branch the voltage converter should be. This does not matter for tap_ratio=1.
I have no idea if there is a convention or if most tools use one specific side, or if it is more or less random. |
I have impedances with ideal transformers at the end in my data. I have added this to pandapower by adding the columns 'ur1_kv' and 'ur2_kv' to the impedance table and calculate an off nominal tap ratio from these. Would you be interested in adding such functionality? In that case I am going to open a pull request.
The column names are of course open for discussion, one could also add a single columns for the tap ratio.
I have tested/compared this with Integral. I would be interested if other tools like powerfactory have this kind of impedance as well?
The text was updated successfully, but these errors were encountered: