Skip to content

Commit 759aaa8

Browse files
committed
restrict shell replacement for salt
tomb-kdf-pbkdf2 requires hexadecimal input, therefore restrict input to those symbols.
1 parent 2a8a57e commit 759aaa8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tomb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1625,7 +1625,7 @@ gen_key() {
16251625
if $(command -v tomb-kdb-pbkdf2-gensalt 1>/dev/null 2>/dev/null); then
16261626
kdfsalt=`tomb-kdb-pbkdf2-gensalt`
16271627
else
1628-
kdfsalt=$(LC_CTYPE=C tr -cd 'a-z0-9' < /dev/random | head -c 64)
1628+
kdfsalt=$(LC_CTYPE=C tr -cd 'a-f0-9' < /dev/random | head -c 64)
16291629
fi
16301630
_message "kdf salt: ::1 kdfsalt::" $kdfsalt
16311631

@@ -1642,8 +1642,8 @@ gen_key() {
16421642
pbkdf2_iter=`tomb-kdb-pbkdf2-getiter $microseconds`
16431643
_message "encoding the password"
16441644
# We use a length of 64bytes = 512bits (more than needed!?)
1645-
tombpass=`tomb-kdb-pbkdf2 $kdf_salt $pbkdf2_iter 64 <<<"${tombpass}"`
1646-
header="_KDF_pbkdf2sha1_${kdf_salt}_${pbkdf2_iter}_64\n"
1645+
tombpass=`tomb-kdb-pbkdf2 $kdfsalt $pbkdf2_iter 64 <<<"${tombpass}"`
1646+
header="_KDF_pbkdf2sha1_${kdfsalt}_${pbkdf2_iter}_64\n"
16471647
;;
16481648
argon2)
16491649
_success "Using Argon2 as KDF"

0 commit comments

Comments
 (0)