Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the callback() #36

Open
idkjs opened this issue Sep 19, 2017 · 2 comments
Open

Remove the callback() #36

idkjs opened this issue Sep 19, 2017 · 2 comments

Comments

@idkjs
Copy link

idkjs commented Sep 19, 2017

Removing the callback might not be a simple thing for some beginners. Edit suggestion below:

  function signal(action) {          
    // return function callback() {     // comment out to remove callback 
      model = update(model, action); 
      view(signal, model, root);     
    // };                               // comment out to remove callback.
  };

Then refresh the browser and check the console.

@idkjs
Copy link
Author

idkjs commented Sep 19, 2017

Also "However this if the "handlers" for each action were "bigger", we would split them out into their own functions e.g:" Is a typo. I tried to link to the line, but there are no line numbers in the readme to link too...

@nelsonic
Copy link
Member

nelsonic commented Oct 31, 2017

@idkjs thanks for opening this issue and making this suggestion.
have you tried removing the callback? what was the effect?
if you have time to create a Pull Request, please do. thanks. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants