Better names?

tests/test_icap_mme.py

@@ -28,33 +28,33 @@ def test_open_dataset_invalid_param():
     ],
 )
 def test_open_dataset(tmp_path, monkeypatch, date, product, data_var):
-    ds1 = open_dataset(date, product=product, data_var=data_var, download=False)
-    assert set(ds1.dims) == {"time", "lat", "lon"}
+    ds = open_dataset(date, product=product, data_var=data_var, download=False)
+    assert set(ds.dims) == {"time", "lat", "lon"}
 
     monkeypatch.chdir(tmp_path)
-    ds2 = open_dataset(date, product=product, data_var=data_var, download=True)
+    ds_dl = open_dataset(date, product=product, data_var=data_var, download=True)
     assert len(sorted(tmp_path.glob("*.nc"))) == 1
-    assert set(ds2.dims) == {"time", "lat", "lon"}
+    assert set(ds_dl.dims) == {"time", "lat", "lon"}
 
-    assert ds2.equals(ds1)
+    assert ds_dl.equals(ds)
 
 
 def test_open_mfdataset(tmp_path, monkeypatch):
     dates = ["2023-08-01", "2023-08-02"]
     product = "C4"
     data_var = "dustaod550"
 
-    ds1 = open_mfdataset(dates, product=product, data_var=data_var, download=False)
-    assert set(ds1.dims) == {"time", "lat", "lon"}
-    assert ds1["dust_aod_mean"].chunks is None, "not Dask-backed"
+    ds = open_mfdataset(dates, product=product, data_var=data_var, download=False)
+    assert set(ds.dims) == {"time", "lat", "lon"}
+    assert ds["dust_aod_mean"].chunks is None, "not Dask-backed"
     assert (
-        ~ds1.time.to_series().duplicated(keep=False)
+        ~ds.time.to_series().duplicated(keep=False)
     ).sum() == 8, "all overlap except first and last day"
 
     monkeypatch.chdir(tmp_path)
-    ds2 = open_mfdataset(dates, product=product, data_var=data_var, download=True)
+    ds_dl = open_mfdataset(dates, product=product, data_var=data_var, download=True)
     assert len(sorted(tmp_path.glob("*.nc"))) == 2
-    assert set(ds2.dims) == {"time", "lat", "lon"}
-    assert ds2["dust_aod_mean"].chunks is not None
+    assert set(ds_dl.dims) == {"time", "lat", "lon"}
+    assert ds_dl["dust_aod_mean"].chunks is not None
 
-    assert ds2.equals(ds1)
+    assert ds_dl.equals(ds)