Skip to content
This repository has been archived by the owner on Aug 2, 2018. It is now read-only.

weird behaviour with mnmly/slider #407

Open
stephenmathieson opened this issue Dec 8, 2014 · 6 comments
Open

weird behaviour with mnmly/slider #407

stephenmathieson opened this issue Dec 8, 2014 · 6 comments

Comments

@stephenmathieson
Copy link
Contributor

for some reason, we're fetching the gh-pages branch of mnmly/slider:

$ echo "require('mnmly/slider')" | duo -t js > /dev/null

     building : from stdin
    installed : mnmly-slider@gh-pages
    installed : [email protected]
    installed : [email protected]
    installed : gorillatron-extend@master
        built : from stdin

i have absolutely no idea how this could be happening...

@dominicbarnes
Copy link
Contributor

Hmm, just checked out yields/gh-resolve to trace this problem down. Looks like git ls-remote lists off both gh-pages and master respectively. (this repo has no other tags) Since no version defaults to * (not master) and gh-pages is listed first, that means it gets chosen.

How we should handle that is another question altogether, should we prefer master when we have no version? Should we just exclude certain things like gh-pages? (weird to "blacklist" stuff like that though)

@stephenmathieson
Copy link
Contributor Author

yeah, i think we should default to master if no tags exist.

unrelated: i ended up using your slider instead. good stuff man 👍

@dominicbarnes
Copy link
Contributor

@stephenmathieson cool deal :)

It's been a while since I did anything with that lib, let me know if you run into any problems.

@dominicbarnes
Copy link
Contributor

Can this be closed now?

@stephenmathieson
Copy link
Contributor Author

it's still an issue until we release gh-resolve and bump its version in package.json

@dominicbarnes
Copy link
Contributor

I'll do the bump+release dance once I can get duojs/gh-resolve#20 fixed. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants