Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New message for privacy pro promotion with origin #124

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

amddg44
Copy link
Collaborator

@amddg44 amddg44 commented Dec 10, 2024

Confirm message conforms to specifications: https://app.asana.com/0/1204739911139421/1208278640816845/f

To test:

  • Update the privacy config URL in the app to this https://jsonblob.com/api/1316093317871755264 (which has the same changes as the privacy config PR)
  • Ensure your device locale is en_US, that you are not subscribed to privacy pro but that you are eligible
  • In RemoteMessagingClient.swift update the debug URL to use the staging URL from the github action below
  • Launch the app and confirm the message is presented. Check the remote message pixels that are being fired and confirm a randomised subset of params are being included e.g.
    image

@amddg44 amddg44 requested a review from quanganhdo December 10, 2024 20:49
@amddg44 amddg44 requested a review from a team as a code owner December 10, 2024 20:49
Copy link

Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amddg44 I wasn't able to get this message to appear correctly, it was failing to match the locale; after some debugging it turns out we only support an array of locale strings, rather than a single value.

I've pushed a commit to use an array, now it looks good to me:

Updated message

@amddg44 amddg44 merged commit aabfc34 into main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants