Malware status support and design updates - macOS (#250)

Author: mgurgel

Package.swift

@@ -30,10 +30,5 @@ let package = Package(
                         .copy("app/img"),
                         .copy ("app/public"),
                         .copy ("app/index.html")]),
-
-        .testTarget(
-            name: "PrivacyDashboardTests",
-            dependencies: ["PrivacyDashboardResources"],
-            path: "swift-package/Tests"),
     ]
 )

integration-tests/DashboardPage.js

@@ -167,6 +167,16 @@ export class DashboardPage {
         await page.locator('[data-page="connection"]').getByText(text).waitFor();
     }
 
+    async clickReportAsSafeLink() {
+        const { page } = this;
+        await page.getByRole('link', { name: 'Report site as safe' }).click();
+    }
+
+    async clickHelpPageLink() {
+        const { page } = this;
+        await page.getByRole('link', { name: 'About our phishing and malware protection' }).click();
+    }
+
     async hasPhishingIcon() {
         const { page } = this;
         await expect(page.locator('#key-insight div').nth(1)).toHaveClass(/hero-icon--phishing/);
@@ -189,6 +199,28 @@ export class DashboardPage {
         await expect(page.locator('#main-nav div')).toContainText('Site May Be Deceptive');
     }
 
+    async hasMalwareIcon() {
+        const { page } = this;
+        await expect(page.locator('#key-insight div').nth(1)).toHaveClass(/hero-icon--phishing/);
+    }
+
+    async hasMalwareHeadingText() {
+        const { page } = this;
+        await expect(page.getByRole('heading', { name: 'privacy-test-pages.site' })).toBeVisible();
+    }
+
+    async hasMalwareWarningText() {
+        const { page } = this;
+        await expect(page.locator('#popup-container')).toContainText(
+            'This site has been flagged for distributing malware designed to compromise your device or steal your personal information.'
+        );
+    }
+
+    async hasMalwareStatusText() {
+        const { page } = this;
+        await expect(page.locator('#main-nav div')).toContainText('Site May Be Deceptive');
+    }
+
     async connectionLinkDoesntShow() {
         await expect(this.connectInfoLink()).not.toBeVisible();
     }

integration-tests/Mocks.js

@@ -347,30 +347,31 @@ export class Mocks {
     }
 
     async calledForAboutLink() {
+        return this.calledForOpenURLInNewTab('https://help.duckduckgo.com/duckduckgo-help-pages/privacy/web-tracking-protections/');
+    }
+
+    async calledForHelpPagesLink() {
+        return this.calledForOpenURLInNewTab('https://duckduckgo.com/duckduckgo-help-pages/privacy/phishing-and-malware-protection/');
+    }
+
+    async calledForReportAsSafeLink(urlParam) {
+        const url = new URL('https://duckduckgo.com/malicious-site-protection/report-error');
+        url.searchParams.set('url', urlParam);
+
+        return this.calledForOpenURLInNewTab(url.toString());
+    }
+
+    async calledForOpenURLInNewTab(url) {
         if (this.platform.name === 'android') {
             const calls = await this.outgoing({ names: ['openInNewTab'] });
-            expect(calls).toMatchObject([
-                [
-                    'openInNewTab',
-                    JSON.stringify({
-                        url: 'https://help.duckduckgo.com/duckduckgo-help-pages/privacy/web-tracking-protections/',
-                    }),
-                ],
-            ]);
+            expect(calls).toMatchObject([['openInNewTab', JSON.stringify({ url })]]);
             return;
         }
         if (this.platform.name === 'macos' || this.platform.name === 'ios') {
             const calls = await this.outgoing({
                 names: ['privacyDashboardOpenUrlInNewTab'],
             });
-            expect(calls).toMatchObject([
-                [
-                    'privacyDashboardOpenUrlInNewTab',
-                    {
-                        url: 'https://help.duckduckgo.com/duckduckgo-help-pages/privacy/web-tracking-protections/',
-                    },
-                ],
-            ]);
+            expect(calls).toMatchObject([['privacyDashboardOpenUrlInNewTab', { url }]]);
             return;
         }
         throw new Error('unreachable. mockCalledForAboutLink must be handled');

integration-tests/macos.spec-int.js

@@ -34,16 +34,46 @@ test('invalid/missing certificate', { tag: '@screenshots' }, async ({ page }) =>
     await dash.showsInvalidCertDetail();
 });
 
-test('phishing warning', { tag: '@screenshots' }, async ({ page }) => {
-    /** @type {DashboardPage} */
-    const dash = await DashboardPage.webkit(page, { platform: 'macos' });
-    await dash.addState([testDataStates.phishing]);
-    await dash.screenshot('phishing-warning.png');
-    await dash.hasPhishingIcon();
-    await dash.hasPhishingHeadingText();
-    await dash.hasPhishingWarningText();
-    await dash.hasPhishingStatusText();
-    await dash.connectionLinkDoesntShow();
+test.describe('phishing & malware protection', () => {
+    test('phishing warning', { tag: '@screenshots' }, async ({ page }) => {
+        /** @type {DashboardPage} */
+        const dash = await DashboardPage.webkit(page, { platform: 'macos' });
+        await dash.addState([testDataStates.phishing]);
+        await dash.screenshot('phishing-warning.png');
+        await dash.hasPhishingIcon();
+        await dash.hasPhishingHeadingText();
+        await dash.hasPhishingWarningText();
+        await dash.hasPhishingStatusText();
+        await dash.connectionLinkDoesntShow();
+    });
+
+    test('malware warning', { tag: '@screenshots' }, async ({ page }) => {
+        /** @type {DashboardPage} */
+        const dash = await DashboardPage.webkit(page, { platform: 'macos' });
+        await dash.addState([testDataStates.malware]);
+        await dash.screenshot('malware-warning.png');
+        await dash.hasMalwareIcon();
+        await dash.hasMalwareHeadingText();
+        await dash.hasMalwareWarningText();
+        await dash.hasMalwareStatusText();
+        await dash.connectionLinkDoesntShow();
+    });
+
+    test('shows report as safe link', async ({ page }) => {
+        /** @type {DashboardPage} */
+        const dash = await DashboardPage.webkit(page, { platform: 'macos' });
+        await dash.addState([testDataStates.malware]);
+        await dash.clickReportAsSafeLink();
+        await dash.mocks.calledForReportAsSafeLink('https://privacy-test-pages.site/security/badware/malware.html');
+    });
+
+    test('shows help page link', async ({ page }) => {
+        /** @type {DashboardPage} */
+        const dash = await DashboardPage.webkit(page, { platform: 'macos' });
+        await dash.addState([testDataStates.malware]);
+        await dash.clickHelpPageLink();
+        await dash.mocks.calledForHelpPagesLink();
+    });
 });
 
 test('insecure certificate', async ({ page }) => {

integration-tests/macos.spec-int.js-snapshots/malware-warning-macos-darwin.png

@@ -51,8 +51,8 @@
                 "localeSettings": {
                     "$ref": "./locale.json"
                 },
-                "phishingStatus": {
-                    "$ref": "./phishing.json"
+                "maliciousSiteStatus": {
+                    "$ref": "./malicious-site.json"
                 },
                 "parentEntity": { "$ref": "./parent-entity.json" },
                 "specialDomainName": {