Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Exact terms interpreted as URLs #4472

Closed
imageck opened this issue Apr 26, 2024 · 2 comments
Closed

[Bug] Exact terms interpreted as URLs #4472

imageck opened this issue Apr 26, 2024 · 2 comments
Labels
bug needs triage

Comments

@imageck
Copy link

imageck commented Apr 26, 2024

Describe the bug

Exact search terms resembling domain names are loaded as pages when double-quoted.

How to Reproduce

  1. Enter "com.android".
  2. It's transformed into http://"com.android".

Expected behavior

Double-quoted, exact terms should not be interpreted as domain names.

Environment

- DDG App Version: 5.197.0
- Device: Samsung Galaxy M14 5G
- OS: Android 14
@github-actions GitHub Actions
Copy link

Thank you for opening an Issue in our Repository.
The issue has been forwarded to the team and we'll follow up as soon as we have time to investigate.
As stated in our Contribution Guidelines, requests for feedback should be addressed via the Feedback section in the Android app.

@joshliebe joshliebe mentioned this issue Jul 12, 2024
Merged
2 tasks
joshliebe added a commit that referenced this issue Jul 19, 2024
@joshliebe
Handle quote input (#4762)
2572ea7 
Task/Issue URL:
https://app.asana.com/0/414730916066338/1207180035648641/f

### Description
Addresses issue raised here:
#4472

### Steps to test this PR
- [x] Enter a URL in quotes (Or containing a quote)
- [x] Verify that the input is treated as a search term and not a URL

### UI changes
| Before  | After |
| ------ | ----- |

![ddg](https://github.com/user-attachments/assets/4ce49027-1c42-4747-af95-15f27d0a97e0)|![ddg_after](https://github.com/user-attachments/assets/70cbda19-7812-46bf-aeb5-a33fc0b9d7eb)
@joshliebe
Copy link
Contributor

Thanks for the report @imageck!

This has been fixed with #4762 and will roll-out with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshliebe @imageck