Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Gradient Editor Mac App uses old syntax #124

Open
dstorey opened this issue Sep 15, 2014 · 1 comment
Open

CSS Gradient Editor Mac App uses old syntax #124

dstorey opened this issue Sep 15, 2014 · 1 comment

Comments

@dstorey
Copy link
Owner

dstorey commented Sep 15, 2014

The App (found on Mac App store) produces code like the following:

/*** CSS Gradient **/
/
Chrome 1-9 and Safari 4-5.0 */
background-image: -webkit-gradient(linear, left top, right top,
color-stop( 0.0, rgb(23, 63, 99) ),
color-stop( 1.0, rgb(213, 213, 213) ));

/* Chrome 10+ Safari 5.1+ Mobile Safari */
background-image: -webkit-linear-gradient(left,
rgb(23, 63, 99),
rgb(213, 213, 213) );

/* Firefox 3.6+ */
background-image: -moz-linear-gradient(left,
rgb(23, 63, 99),
rgb(213, 213, 213) );

/* IE 10+ */
background-image: -ms-linear-gradient(left,
rgb(23, 63, 99),
rgb(213, 213, 213) );

/* Opera 11.10+ */
background-image: -o-linear-gradient(left,
rgb(23, 63, 99),
rgb(213, 213, 213) );

/* W3C */
background-image: linear-gradient(left,
rgb(23, 63, 99),
rgb(213, 213, 213) );

Issues:

The W3C version is incorrect. Should use to right instead of left.
The MS version was never needed.

Fix:

Remove -ms- version
Update syntax for unprefixed using the to keyword and reversing the direction.

@dstorey
Copy link
Owner Author

dstorey commented Sep 15, 2014

Reply from developer: “Wow. I confess I haven’t looked at the state of CSS Gradients in awhile. Thanks for the heads up on this. When I wrote this gradients were in a state of flux, therefore I put in all the prefixes. Time to revisit this and get an update out. ”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant